fix(project): set requires-python >=3.12 in the BMA template - #2492
Merged
Merged
Conversation
Mirrors #2491. Without a minimum, uv run client.py can pick the macOS system Python 3.9, which openai does not support.
agentcore-devx-automation
Bot
added
agentcore-harness-reviewing
![agentcore-devx-automation[bot]](https://avatars.githubusercontent.com/u/2232217?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
AgentCore Harness Review
Verdict: Looks good
Small, well-scoped template fix. Confirmed against the repo:
DockerfilerunsRUN uv python install --defaultat line 27 andCOPY pyproject.tomlat line 33, sorequires-python = ">=3.12"acts as a floor and does not pin the image's Python version — matches what the README and PR description claim.- The new regex assertion in
bedrockManagedAgents.test.ts(RUN uv python install --default\n[\s\S]*COPY pyproject\.toml) correctly guards that ordering, so a future reorder that would inadvertently makerequires-pythonpin the image Python would fail the test. >=3.12is consistent with theopenai>=3.16.2dev dependency's own Python floor, souv run client.pyon a macOS host with only system Python 3.9 will now do the right thing.- No telemetry or mocking concerns — this is a static template + assertion change.
Nothing blocking. LGTM.
agentcore-devx-automation
Bot
removed
the
agentcore-harness-reviewing
Contributor
|
Claude Security Review: no high-confidence findings. (run) |
agentcore-devx-automation
Bot
removed
the
claude-security-reviewing
nborges-aws
approved these changes
Sep 30, 2026
aidandaly24
approved these changes
Sep 30, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## refactor #2492 +/- ##
=========================================
Coverage 97.39% 97.39%
=========================================
Files 642 642
Lines 46801 46801
=========================================
Hits 45584 45584
Misses 1217 1217 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Mirrors #2491 to
refactor. The BMA templatepyproject.tomlhas norequires-python, so on macOSuv run client.pycan pick the system Python 3.9, andopenaidoes not install on it.This sets
requires-python = ">=3.12". It is a minimum only. The Dockerfile runsuv python install --defaultbefore it copiespyproject.toml, so the image keeps the latest Python. The README line forpyproject.tomlsays why the minimum is there, and the BMA contract test checks the minimum and the Dockerfile order.Related Issue
No issue. Mirrors #2491, which came from feedback on the BMA getting started guide.
Documentation PR
Template README updated in this PR.
Type of Change
Testing
bun test(3950 pass)agentcore create --template bedrock-managed-agents, and confirmed the generatedpyproject.tomland README. No deploy, the change does not touch deployed resources.bun run typecheckbun run lint:checkbun run format:checkbun run buildChecklist